Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encryption for RF69_COMPAT #100

Open
ghost opened this issue Dec 27, 2016 · 9 comments
Open

encryption for RF69_COMPAT #100

ghost opened this issue Dec 27, 2016 · 9 comments
Labels

Comments

@ghost
Copy link

ghost commented Dec 27, 2016

rf12_encrypt(KEY) is working fine when using rf12 modules (without RF69_COMPAT). When using rfm69cw modules with RF69_COMPAT sending and receiving is working fine but the encryption is just ignored (seems to be not implemented). Any ideas?

@jcw jcw added the bug label Dec 27, 2016
@jcw
Copy link

jcw commented Dec 27, 2016

Ah, that's probably a bug - with the RF12 driver, an XTEA-based software implementation is used, whereas the RF69 driver uses built-in h/w AES for native mode. I suspect that the compat mode has never been used or implemented.

@ghost
Copy link
Author

ghost commented Dec 27, 2016

Is it possible to use this library in native mode - without the RF69_COMPAT flag (when every module in my network is using the rfm69cw) and enable encryption? As I cannot find any examples / implementations for that.

@jcw
Copy link

jcw commented Dec 27, 2016

Whoops, had a better look - you're right, the Arduino/JeeLib version of RF69 does not support encryption in native mode either.

I can not fix this right now - if you're willing to wait until end of next week, I can have a go at either bringing the RF12 encryption logic into the RF69 compat mode driver, or enabling the AES mode in the native version (I'm not sure at this point which will be easier).

@ghost
Copy link
Author

ghost commented Dec 27, 2016

Sure :-) Thank you.

@ghost
Copy link
Author

ghost commented Jan 23, 2017

Any news?

@FullyScaled
Copy link

Currently having the same problem. Any chance you will invest time into this in the near future?

@jcw
Copy link

jcw commented May 22, 2017

I'm afraid that won't happen any day soon (at least not by me), despite my earlier promise. It's been quite a while since I worked on the RF12 and RF69 compatibility code in JeeLib.

@JohnOH
Copy link
Collaborator

JohnOH commented May 22, 2017

It might be interesting to remove line 32 from RF69_compat.h in jeelib.
#define rf12_encrypt rf69_encrypt
Not tested it and no guarantees!

@JohnOH
Copy link
Collaborator

JohnOH commented May 22, 2017

On second thoughts that would work on the wrong buffer and thereby not achieve the objective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants