More advanced DFS compatibility checks #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid setting the SMB2_FLAGS_DFS_OPERATIONS flag in the SMB header if the server did not report it as supporting DFS operations during the negotiation phase. This should hopefully fix up some problems when the server errors in the case it doesn't support DFS operations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 24 24
Lines 5112 5112
=======================================
Hits 5064 5064
Misses 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This didn't help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid setting the SMB2_FLAGS_DFS_OPERATIONS flag in the SMB header if the server did not report it as supporting DFS operations during the negotiation phase. This should hopefully fix up some problems when the server errors in the case it doesn't support DFS operations.
Fixes: #242