Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2 #390

Closed
hugovk opened this issue Oct 4, 2019 · 8 comments
Closed

Drop support for Python 2 #390

hugovk opened this issue Oct 4, 2019 · 8 comments

Comments

@hugovk
Copy link
Member

hugovk commented Oct 4, 2019

Python 2 reaches end-of-life on 2020-01-01.

See https://python3statement.org for a list of projects which have pledged to drop support for Python 2 on or before its EOL.

I'd like to suggest making a release soonish with the recent changes that still supports Python 2.7, and then drop it.

That'll allow newer features of Python to be used, and also some vendored code can be removed (eg. #362 (comment)) and deal with some other issues (eg. #268 (comment)).

@claudep
Copy link
Contributor

claudep commented Oct 4, 2019

+1. What would you suggest for the next version numbering, 0.13.1?

@hugovk
Copy link
Member Author

hugovk commented Oct 4, 2019

I don't know the version scheme being used so far, but if we look at the popular SemVer:

  1. Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

  2. Version 1.0.0 defines the public API. The way in which the version number is incremented after this release is dependent on this public API and how it changes.

...

How do I know when to release 1.0.0?

If your software is being used in production, it should probably already be 1.0.0. If you have a stable API on which users have come to depend, you should be 1.0.0. If you’re worrying a lot about backwards compatibility, you should probably already be 1.0.0.

Tablib was downloaded nearly 300,000 times last month, I think it's about time for 1.0.0 :)

@claudep
Copy link
Contributor

claudep commented Oct 4, 2019

I'm not very comfortable releasing 1.0.0 right now, I'd rather stick with 0.13.1 or 0.14.0 and release 1.0.0 after dropping Python 2. Thoughts?

@hugovk
Copy link
Member Author

hugovk commented Oct 4, 2019

Agreed. (I mixed up the next release with the drop release.)

SemVer says:

  • For 0.y.z releases, anything goes.

  • For 1+.y.z releases, bump the patch number x.y.Z when there's bugfixes.

  • For 1+.y.z releases, bump the minor number x.Y.z when there's new features (and optionally also bugfixes).

I'd probably go for 0.14.0.

@peymanslh
Copy link
Member

Hello @hugovk @claudep
Can I work on this issue and send a pull request?

@claudep
Copy link
Contributor

claudep commented Oct 4, 2019

Fine for me. It will probably need some rebasing at the time we're ready to commit it.

@peymanslh
Copy link
Member

I sent a pr: #394
@claudep

@hugovk hugovk mentioned this issue Oct 18, 2019
@claudep
Copy link
Contributor

claudep commented Oct 19, 2019

PR #394 was merged "manually".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants