Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-oauth throws intermittent InternalOAuthErrors on fast connections #163

Open
8bitDesigner opened this issue Jul 25, 2022 · 2 comments · May be fixed by jaredhanson/passport-oauth1#25
Open

node-oauth throws intermittent InternalOAuthErrors on fast connections #163

8bitDesigner opened this issue Jul 25, 2022 · 2 comments · May be fixed by jaredhanson/passport-oauth1#25

Comments

@8bitDesigner
Copy link

Hi all, there's an existing bug with passport-google-oauth2 where, due to an upstream issue in node-oauth 0.9.0, OAuthing into Google accounts fails intermittently over fast connections.

Good news! The upstream issue has been fixed and published as node-oauth 0.10.0. However passport-google-oauth2 depends on this package, and this package is pinned at node-oauth 0.9.x. Can you bump this dependency to 0.10.0 and publish a new version?
@Quentin-Danjou
Copy link
Contributor

Here is the change made on node-oauth (named oauth in the dependencies) from the current version used by passport-oauth2 (0.9.x) to the 0.10.0: ciaranj/node-oauth@0.9.15...0.10.0 (made by ciaranj/node-oauth#363)

Once the version will be bumped this will solve several duplicated issues in passport-google-oauth2 as said by @8bitDesigner, such as jaredhanson/passport-google-oauth2#87, jaredhanson/passport-google-oauth2#64, but also may be related to some of the issues of that repo such as involving InternalOAuthError: Failed to obtain access token: #155, #113

Quentin-Danjou added a commit to Quentin-Danjou/passport-oauth2 that referenced this issue Aug 12, 2022
@Quentin-Danjou
Bump oauth from 0.9.x to 0.10.x
1f8ff8c 
This is solving multiple issues of `passport-google-oauth2` as stated in issue jaredhanson#163
@Quentin-Danjou Quentin-Danjou mentioned this issue Aug 12, 2022
Merged
@Grafnus Grafnus mentioned this issue Nov 20, 2022
Closed
@blargism
Copy link

blargism commented Apr 2, 2023

This is a pretty critical issue. Can it please be prioritized? My only recourse right now is to fork and patch. Given the number or forks it seems many others have also done so.

Let me know if I or other community members can help.

@robigan robigan mentioned this issue May 12, 2023
Closed
gabegorelick added a commit to gabegorelick/passport-oauth1 that referenced this issue Oct 18, 2024
@gabegorelick
Upgrade oauth dependency
29c75e4 
Mostly for ciaranj/node-oauth#363, which fixes
jaredhanson/passport-oauth2#163. I haven't been able to reproduce that
issue with passport-twitter, but in theory it should be possible.

I'm not aware of any breaking changes in `oauth`.

See https://github.com/ciaranj/node-oauth/commits
gabegorelick added a commit to gabegorelick/passport-oauth1 that referenced this issue Oct 18, 2024
@gabegorelick
Upgrade oauth dependency
184f5e6 
Mostly for ciaranj/node-oauth#363, which fixes
jaredhanson/passport-oauth2#163. I haven't been able to reproduce that
issue with passport-oauth1, but in theory it may be possible.

I'm not aware of any breaking changes in `oauth`.

See https://github.com/ciaranj/node-oauth/commits
@gabegorelick gabegorelick linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade oauth dependency gabegorelick/passport-oauth1
3 participants
@8bitDesigner @blargism @Quentin-Danjou