Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

would be possible to have f2fstune #19

Open
lu-zero opened this issue Mar 4, 2023 · 0 comments
Open

would be possible to have f2fstune #19

lu-zero opened this issue Mar 4, 2023 · 0 comments

Comments

@lu-zero
Copy link

lu-zero commented Mar 4, 2023

I tried to figure out how to change the f2fs label and I could not come up with a way.
jaegeuk pushed a commit that referenced this issue Jul 12, 2023
f2fs: should use inode when updating file offset
bbde2dd 
In indirect or double indirect node blocks, we should use parent inode
information to check the offset.

This fixes the below fsck complaint.

Info: MKFS version
  "Linux version 6.5.0-rc1-custom (root@file) (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.37) #19 SMP PREEMPT_DYNAMIC Mon Jul 10 19:18:40 UTC 2023"
Info: FSCK version
  from "Linux version 6.5.0-rc1-custom (root@file) (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.37) #19 SMP PREEMPT_DYNAMIC Mon Jul 10 19:18:40 UTC 2023"
    to "Linux version 6.5.0-rc1-custom (root@file) (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.37) #19 SMP PREEMPT_DYNAMIC Mon Jul 10 19:18:40 UTC 2023"
Info: superblock features = 2499 :  encrypt extra_attr project_quota quota verity compression
Info: superblock encrypt level = 0, salt = 00000000000000000000000000000000
Info: checkpoint stop reason: shutdown(63)
Info: Segments per section = 1
Info: Sections per zone = 1
Info: total FS sectors = 134217728 (65536 MB)
Info: CKPT version = 2c573c1e
Info: Checked valid nat_bits in checkpoint
Info: checkpoint state = c2 :  nat_bits crc orphan_inodes sudden-power-off
[FSCK] Check node 1 / 229537 (0.00%)
[FSCK] Check node 22954 / 229537 (10.00%)
[FSCK] Check node 45907 / 229537 (20.00%)
[FSCK] Check node 68860 / 229537 (30.00%)
[FSCK] Check node 91813 / 229537 (40.00%)
[FSCK] Check node 114766 / 229537 (50.00%)
[FSCK] Check node 137719 / 229537 (60.00%)
[FSCK] Check node 160672 / 229537 (70.00%)
[FSCK] Check node 183625 / 229537 (80.00%)
[FSCK] Check node 206578 / 229537 (90.00%)
[ASSERT] (fsck_chk_inode_blk:1213)  --> ino: 0xfccd has i_blocks: 000000ce, but has 204 blocks
[FSCK] Check node 229531 / 229537 (100.00%)

[FSCK] Max image size: 20600 MB, Free space: 44936 MB
[FSCK] Unreachable nat entries                        [Ok..] [0x0]
[FSCK] SIT valid block bitmap checking                [Ok..]
[FSCK] Hard link checking for regular file            [Ok..] [0x3696]
[FSCK] valid_block_count matching with CP             [Fail] [0x4eff19, 0x4eff17]
[FSCK] valid_node_count matching with CP (de lookup)  [Ok..] [0x380a1]
[FSCK] valid_node_count matching with CP (nat lookup) [Ok..] [0x380a1]
[FSCK] valid_inode_count matched with CP              [Ok..] [0x34519]
[FSCK] free segment_count matched with CP             [Ok..] [0x6e1b]
[FSCK] next block offset is free                      [Ok..]
[FSCK] fixing SIT types
[FSCK] other corrupted bugs                           [Fail]

Signed-off-by: Jaegeuk Kim <[email protected]>
jaegeuk pushed a commit that referenced this issue Jul 12, 2023
f2fs: should use inode when updating file offset
a35353d 
In indirect or double indirect node blocks, we should use parent inode
information to check the offset.

This fixes the below complaint with a reproducer.

$ mount -t f2fs -o discard,compress_extension=* /dev/$DEV $TESTDIR
$ f2fs_io write 1 3944 4 zero buffered $TESTDIR/a
$ umount /dev/$DEV
$ fsck.f2fs /dev/$DEV
Info: MKFS version
  "Linux version 6.5.0-rc1-custom (root@file) (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.37) #19 SMP PREEMPT_DYNAMIC Mon Jul 10 19:18:40 UTC 2023"
Info: FSCK version
  from "Linux version 6.5.0-rc1-custom (root@file) (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.37) #19 SMP PREEMPT_DYNAMIC Mon Jul 10 19:18:40 UTC 2023"
    to "Linux version 6.5.0-rc1-custom (root@file) (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.37) #19 SMP PREEMPT_DYNAMIC Mon Jul 10 19:18:40 UTC 2023"
Info: superblock features = 3088 :  extra_attr quota casefold compression
Info: superblock encrypt level = 0, salt = 00000000000000000000000000000000
Info: Segments per section = 1
Info: Sections per zone = 1
Info: total FS sectors = 134217728 (65536 MB)
Info: CKPT version = 284f1e2f
Info: Checked valid nat_bits in checkpoint
Info: checkpoint state = c5 :  nat_bits crc compacted_summary unmount
[ASSERT] (fsck_chk_inode_blk:1189)  --> ino: 0x6 has i_blocks: 00000007, but has 6 blocks

[FSCK] Max image size: 378 MB, Free space: 65158 MB
[FSCK] Unreachable nat entries                        [Ok..] [0x0]
[FSCK] SIT valid block bitmap checking                [Ok..]
[FSCK] Hard link checking for regular file            [Ok..] [0x0]
[FSCK] valid_block_count matching with CP             [Fail] [0xf, 0xe]
[FSCK] valid_node_count matching with CP (de lookup)  [Ok..] [0x6]
[FSCK] valid_node_count matching with CP (nat lookup) [Ok..] [0x6]
[FSCK] valid_inode_count matched with CP              [Ok..] [0x4]
[FSCK] free segment_count matched with CP             [Ok..] [0x7f3f]
[FSCK] next block offset is free                      [Ok..]
[FSCK] fixing SIT types
[FSCK] other corrupted bugs                           [Fail]
Do you want to fix this partition? [Y/N]

Signed-off-by: Jaegeuk Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lu-zero