Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unauthenticated users to view games #467

Closed
jackstenglein opened this issue Apr 23, 2024 · 4 comments
Closed

Enable unauthenticated users to view games #467

jackstenglein opened this issue Apr 23, 2024 · 4 comments

Comments

@jackstenglein
Copy link
Owner

We want to allow people in the Dojo to share their annotations with people outside the Dojo, without those outside the Dojo having to sign up to view them.

Unauthenticated users should be able to view the game page, see all comments, look at the explorer on the game page, etc. However, they should not be able to post comments and if they try to click the "View all games in this position" button in the explorer, then they should be prompted to log in on the new tab that opens.

@chao-mu
Copy link
Collaborator

chao-mu commented Apr 24, 2024

Is the permissions model here "anyone with the link has read only access"?

Is this a separate visibility the user sets or all "public" ones?

What's the deal about discoverability? Should unauthenticated users be able to view/search for public games? If so, that seems like a stretch item.

@jackstenglein
Copy link
Owner Author

Yes, anyone who has the link should have access to that page. This should happen for any public or unlisted game.

Unauthenticated users should not be able to view the game list page. If they try, they should get redirected to the sign in page (which is what currently happens)

@chao-mu
Copy link
Collaborator

chao-mu commented Apr 26, 2024

Should this be closed now that it's merged?

@jackstenglein
Copy link
Owner Author

Closed in #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants