Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lockfile for the CLI package #88

Open
Lucidiot opened this issue Jan 2, 2022 · 1 comment
Open

Add a lockfile for the CLI package #88

Lucidiot opened this issue Jan 2, 2022 · 1 comment
Assignees
Labels

Comments

@Lucidiot
Copy link

Lucidiot commented Jan 2, 2022

I am trying to package svgbob for Alpine. The universal command to fetch the dependencies with any Rust package there is cargo fetch --locked, which uses the Cargo.lock file to make sure that we get the exact dependencies that were used for the official release, not any dependency that could have been released later and caused a bug or something similar.

As explained in Cargo's FAQ, a Cargo.lock file should be checked into the repository to ensure that builds are reproducible, but only for binaries. So in this repo, this should mean there should be a packages/cli/Cargo.lock, and not a packages/svgbob/Cargo.lock.

Alpine's packaging rules are pretty strict, so this is likely to be the only thing blocking me from getting this package out of testing. This might also help any future distro package maintainers who build from source.

@ivanceras ivanceras self-assigned this Jan 2, 2022
@ivanceras ivanceras added the bug label Jan 2, 2022
@ivanceras
Copy link
Owner

Thank you @Lucidiot for filing this issue. I will include the cli/Cargo.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants