Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session data display in extensions: binary data shown as 'null' #378

Open
tminich opened this issue Feb 3, 2020 · 2 comments
Open

Session data display in extensions: binary data shown as 'null' #378

tminich opened this issue Feb 3, 2020 · 2 comments

Comments

@tminich
Copy link
Contributor

tminich commented Feb 3, 2020

If you have binary data in your session both Firefox and Chrome extensions show it as 'null' in the Request section. I don't expect it to be actually displayed, but it would be nice to see something like '<Binary Data (Length 64)>' or similar instead as 'null' is quite misleading.

@itsgoingd
Copy link
Owner

Interesting, we already have a code that stores binary database bindings in hex format

https://github.com/itsgoingd/clockwork/blob/master/Clockwork/DataSource/EloquentDataSource.php#L175

I guess we could use a similar code when serializing data globally. I'm a worried about the performance impact of running preg_match possibly hundreds or thousands of times though. Will need to investigate more.

@tminich
Copy link
Contributor Author

tminich commented Feb 3, 2020

Well, for me personally the data itself doesn't really matter, I'd just like a 'something there' instead of 'null' =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants