Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Improve internal composable API for className #146

Open
itsdouges opened this issue Jun 30, 2019 · 1 comment
Open

Improve internal composable API for className #146

itsdouges opened this issue Jun 30, 2019 · 1 comment

Comments

@itsdouges
Copy link
Owner

itsdouges commented Jun 30, 2019

We can't easily compose things from className and keyframes ATM. Since this library wants to try and do things via CSS animation (over JS animation) we need to come up with a solution.

API thoughts:

setChildProps({
  // composable style
  style: prevStyle => ({ ...prevStyle }),

  // composable class via objects
  classNameStyle: prevStyle => ({ ...prevStyle }),

  // composable keyframes
  keyframes: prevKeyframes => compose => compose(prevKeyframes, newKeyframes, 'animation-name'),
});
  • Removes className from API (deprecated first)
  • Adds classNameStyle to API
  • Remove emotion dependency
@itsdouges itsdouges changed the title Remove emotion dependency Remove emotion dependency, replace with composable keyframes/animation API Jul 1, 2019
@itsdouges itsdouges changed the title Remove emotion dependency, replace with composable keyframes/animation API Improve internal composable API Jul 3, 2019
@itsdouges
Copy link
Owner Author

Keyframes is done.

@itsdouges itsdouges changed the title Improve internal composable API Improve internal composable API for className Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant