Figure out how to do session expiration

[untitaker]

No description provided.

[untitaker]

rwf2/cookie-rs#62

[untitaker]

Also fuck generality, I'll do this as per-backend param.

[zoumi]

Will you use this :https://github.com/zoumi/iron_config ?

[untitaker]

What stops you from already using it? You can just pass the data from iron-config into iron-sessionstorage during init

…

On 12 February 2017 16:01:07 CET, zoumi ***@***.***> wrote: Will you use this :https://github.com/zoumi/iron_config ? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #3 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[frjonsen]

Is there currently a simple way of doing this for SignedCookieBackend? I'm currently doing it by using SignedCookieBackend::set_cookie_modifier, but this takes takes a function which takes an immutable cookie. I end up having to do something like this:

fn set_cookie_attributes(cookie: Cookie) -> Cookie {
    let mut c = cookie.clone();
    c.max_age = Some(1);
    c
}

While it does work, it seems a bit unnecessary.

[untitaker]

The function doesn't take an immutable or mutable cookie, it just takes a cookie by value. Whether you want that cookie to be mutable or not is your choice then. ```Rust fn set_cookie_attributes(mut cookie: Cookie) -> Cookie { cookie.max_age = Some(1); cookie } ``` Also it's not safe to just set `max_age`, because the user can forge that to whichever value they want. Whether this matters or not depends on your threat model. It's better to set this as a session value and have your own expiration logic.

…

On Wed, Mar 01, 2017 at 02:21:23AM -0800, Fredrik Jonsén wrote: Is there currently a simple way of doing this for SignedCookieBackend? I'm currently doing it by using SignedCookieBackend::set_cookie_modifier, but this takes takes a function which takes an immutable cookie. I end up having to do something like this: ```Rust fn set_cookie_attributes(cookie: Cookie) -> Cookie { let mut c = cookie.clone(); c.max_age = Some(1); c } ``` While it does work, it seems a bit unnecessary. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #3 (comment)

[frjonsen]

Ah, I see. My mistake then. New to Rust, and still trying to figure out the syntax in some cases.

[janhohenheim]

Is this implemented for the redis backend yet? If yes, could you give me a small example?

[untitaker]

It is not implemented for any interface.

…

On 27 March 2017 00:48:19 CEST, Jan Nils Ferner ***@***.***> wrote: Is this implemented for the redis backend yet? If yes, could you give me a small example? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #3 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.