Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate encrypted lookup path entirely #127

Closed
masih opened this issue Jun 21, 2023 · 2 comments · Fixed by #150
Closed

Separate encrypted lookup path entirely #127

masih opened this issue Jun 21, 2023 · 2 comments · Fixed by #150

Comments

@masih
Copy link
Member

masih commented Jun 21, 2023 •
edited
Loading

The double hash multicodec code is not dedicated to encrypted records. Therefore we cannot implicitly assume that it represents one.

Separate encrypted lookup path by adding /encrypted prefix.

Context:
@gammazero
Copy link
Collaborator

Does this only apply to the delegatedTranslator at the /routing/v1/ path, or does this apply to all queries (/cid/, /multihash/, etc.)?

@masih
Copy link
Member Author

masih commented Aug 28, 2023

All queries.

For HTTP delegated routing, the semantics are not finalised though close to be.
For IPNI we should separate, encrypted queries from non encrypted and remove implicit assuptions that the multicodec would be of kind double hash.

gammazero added a commit that referenced this issue Aug 29, 2023
@gammazero
Separate encrypted and non-encrypted paths
0013039 
Do not rely on dbl-sha2-256 codec to determine if querying for encrypted or non-encrypted multihash. Use URL path instead.

Fixes #127

Requires ipni/dhstore#84
@gammazero gammazero mentioned this issue Aug 29, 2023
Merged
gammazero added a commit that referenced this issue Sep 9, 2023
@gammazero
Separate encrypted and non-encrypted paths (#150)
4aff8e5 
* Do not rely on dbl-sha2-256 codec to determine if querying for encrypted or non-encrypted multihash. Use URL path instead.

Requires ipni/dhstore#84

Fixes #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate encrypted and non-encrypted paths ipni/indexstar
2 participants
@masih @gammazero