-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway: run Unicode Normalisation Forms on path gateway inputs #457
Comments
For reference: https://go.dev/blog/normalization |
Thank you for raising this.
What is the problem we are trying to solve? If so, I think the best we could do UX-wise, is to retry on "not found" and trying normalised (NFC) / decomposed (NFD) forms (to cover both variants). This way we don't break datasets where file already exists, but still fix HTTP 404 for cases where only file in different notation exists. If this is something we want to do, should be included in #453 to ensure consistency across web contexts (which we will then reference from https://specs.ipfs.tech/http-gateways/path-gateway/). But this introduces a magical behavior which hides the underlying problem macOS introduced – see my comment in ipfs/kubo#10286 (comment). Perhaps it is better to NOT fix reads, and instead give users ability to force specific normalization during data onboarding instead? (like |
See context here: ipfs/kubo#10286 (comment)
Relevant Unicode spec: https://unicode.org/reports/tr15/
The text was updated successfully, but these errors were encountered: