Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to non-experimental pubsub #7350

Closed
Stebalien opened this issue May 22, 2020 · 1 comment
Closed

Roadmap to non-experimental pubsub #7350

Stebalien opened this issue May 22, 2020 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

The ipfs pubsub subsystem is currently an MVP and needs some hardening before it can truly be considered "ready":

  1. Use pubsub's new built-in discovery system instead of literally putting a block advertising our interest in the topic into the blockstore.
  2. Manage pubsub topics. This may involve changing the API. At the moment, calling pubsub publish will "join" the topic permanently.
  3. Pass pubsub.WithReadyness(pubsub.MinTopicSize(1)) on publish so we don't publish into the void. We can pass a context with a short (1-10s) timeout to avoid blocking forever.
  4. Use the non-deprecated topic.Publish function so we can actually pass in a context.
@Stebalien
Copy link
Member Author

Missed #6621.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant