Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipfs/go-bitswap] Passing Auth to exchange.Fetcher requests #77

Open
hannahhoward opened this issue Mar 25, 2022 · 0 comments
Open

[ipfs/go-bitswap] Passing Auth to exchange.Fetcher requests #77

hannahhoward opened this issue Mar 25, 2022 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@hannahhoward
Copy link
Contributor

One thing I don't see covered in ipfs/go-bitswap#543 or ipfs/specs#270 is how we actually pass an auth token to a bitswap want from the standpoint of the library consumer.

I can see a couple mechanisms:

  1. Continue the session id in context thread (https://github.com/ipfs/go-ipfs-exchange-interface/pull/9/files) and extend it for auth (i.e. auth per session)
  2. Modify the exchange.Fetcher function parameters

The first sounds simpler, but is quite limited. I think we need to figure out the granularity of scope we support for passing tokens. Should our mapping be simply token per session? Token per GetBlock/GetBlocks requests? Token per peer that may send us the block? Any combination thereof?

For reference: a go-data-transfer integration will be easiest if we support per-peer, but that's also the hardest to implement :(

@hannahhoward hannahhoward added the need/triage Needs initial labeling and prioritization label Mar 25, 2022
@Jorropo Jorropo changed the title Passing Auth to exchange.Fetcher requests [ipfs/go-bitswap] Passing Auth to exchange.Fetcher requests Jan 27, 2023
@Jorropo Jorropo transferred this issue from ipfs/go-bitswap Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants