From 3b28f3aaf0c0d8d969bc53d1b79b3cb4cbae4e37 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 20 Nov 2023 17:24:11 -0500 Subject: [PATCH] Revert "fix(icon): verify the icon loads in the lifecycle (#1278)" This reverts commit 7f7f346af47f45531046e1d2f1a88f53acee77fa. --- src/components/icon/icon.tsx | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/components/icon/icon.tsx b/src/components/icon/icon.tsx index 10cdd0051..b6a9f5fcd 100755 --- a/src/components/icon/icon.tsx +++ b/src/components/icon/icon.tsx @@ -12,7 +12,6 @@ export class Icon { private io?: IntersectionObserver; private iconName: string | null = null; private inheritedAttributes: { [k: string]: any } = {}; - private didLoadIcon = false; @Element() el!: HTMLElement; @@ -95,18 +94,6 @@ export class Icon { }); } - componentDidLoad() { - /** - * Addresses an Angular issue where property values are assigned after the 'connectedCallback' but prior to the registration of watchers. - * This enhancement ensures the loading of an icon when the component has finished rendering and the icon has yet to apply the SVG data. - * This modification pertains to the usage of Angular's binding syntax: - * `` - */ - if (!this.didLoadIcon) { - this.loadIcon(); - } - } - disconnectedCallback() { if (this.io) { this.io.disconnect(); @@ -151,7 +138,6 @@ export class Icon { // async if it hasn't been loaded getSvgContent(url, this.sanitize).then(() => (this.svgContent = ioniconContent.get(url))); } - this.didLoadIcon = true; } }