Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict test case found for type definition. #1566

Open
TotooriaHyperion opened this issue Apr 19, 2024 · 0 comments
Open

Conflict test case found for type definition. #1566

TotooriaHyperion opened this issue Apr 19, 2024 · 0 comments

Comments

@TotooriaHyperion
Copy link

TotooriaHyperion commented Apr 19, 2024

I'm trying to improve BindingToSyntax type definition because it lost type check for toConstructor, toFactory to be compatible with type inferred from bind(XXX) ...etc

But I found conflict test cases:
image

Expected Behavior

types between BindingToSyntax should be compatible with generic type param of toConstructor.

Current Behavior

The right bottom example of BindingToSyntax<T> requires toConstructor(constructor: Newable<T>)
But the rest 3 examples of BindingToSyntax<Newable<T>> requires toConstructor(constructor: Newable<T>)

Possible Solution

image

This gives the toConstructor ability to infer the type from BindingToSyntax<T> if T is Newable or returns type never

But the Ninja test fails because it's using wrong types.

I need to change the test case of toConstructor<Ninja>(Ninja).

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop or mobile):
  • Link to your project:

Stack trace

@TotooriaHyperion TotooriaHyperion changed the title Ambiguous test case found for type definition. Conflict test case found for type definition. Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant