Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]Add option to being able to mark build outputs completed if all required tests are passed #6006

Open
2 tasks done
martonmiklos opened this issue Nov 29, 2023 · 4 comments · May be fixed by #8061
Open
2 tasks done
Labels
build Build orders enhancement This is an suggested enhancement or new feature
Milestone

Comments

@martonmiklos
Copy link
Contributor

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find a similar feature request

Problem statement

When thinking on the #5037 the following came into my mind: in some scenarios it would be useful if the test results could mark the given build output completed.
For e.g. in the case if the final test passed (and the build output is ready for completion see #5037) then the output could be marked completed.

Suggested solution

Add a "Finish build output if this test passed" parameter to the test templates.
Maybe if we implement the #5037 we need to reword this a bit to something "Finish build output if this (and all other required) tests are passed"

Describe alternatives you've considered

Examples of other systems

Do you want to develop this?

  • I want to develop this.
@martonmiklos martonmiklos added enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Nov 29, 2023
@SchrodingersGat SchrodingersGat added build Build orders and removed triage:not-checked Item was not checked by the core team labels Dec 6, 2023
Copy link
Contributor

github-actions bot commented Feb 4, 2024

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Feb 4, 2024
@SchrodingersGat
Copy link
Member

Not stale - being worked on in #6057

@github-actions github-actions bot removed the inactive Indicates lack of activity label Feb 5, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Apr 6, 2024
@martonmiklos
Copy link
Contributor Author

Still interested in finishing it

@SchrodingersGat SchrodingersGat removed the inactive Indicates lack of activity label Apr 6, 2024
@SchrodingersGat SchrodingersGat added this to the horizon milestone Apr 6, 2024
martonmiklos added a commit to martonmiklos/InvenTree that referenced this issue Aug 27, 2024
martonmiklos added a commit to martonmiklos/InvenTree that referenced this issue Sep 3, 2024
martonmiklos added a commit to martonmiklos/InvenTree that referenced this issue Sep 3, 2024
martonmiklos added a commit to martonmiklos/InvenTree that referenced this issue Sep 3, 2024
martonmiklos added a commit to martonmiklos/InvenTree that referenced this issue Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build orders enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants