Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense: offer new completions after selecting a completion with a triggering character #38

Open
isc-tleavitt opened this issue Dec 15, 2022 · 3 comments

Comments

@isc-tleavitt
Copy link
Contributor

isc-tleavitt commented Dec 15, 2022

For example:
select * from (offers schemas)
pick a schema, get:
select * from MySchema.

To get table completions offered, I need to backspace the . and retype it, THEN it'll offer table suggestions. I shouldn't need to do that.

(from a bit of digging, this might be upstream all the way in VSCode.)

@gjsjohnmurray
Copy link
Collaborator

@isc-tleavitt is this a consequence of the way your recent PR for schemas adds the . at the end of what it inserts?

@isc-tleavitt
Copy link
Contributor Author

isc-tleavitt commented Dec 16, 2022

@gjsjohnmurray I suppose this wouldn't be an issue if the user needed to type the . in the first place. (But I don't think the user should need to.)

@gjsjohnmurray
Copy link
Collaborator

Maybe microsoft/vscode#82236 is relevant.

Another issue linked from there mentions how some extensions use CompletionItem.command to trigger a second set of suggestions. I'm guessing they run editor.action.triggerSuggest but I haven't verified this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants