-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
company name has unwanted characters if the name has apostrophe or & in it #251
Comments
Also affected by this bug when company name contains apostrophe character, which pretty common. Version Infointercom-java: 2.8.0 |
Some more info on this bug. Only responses contain the bad Requests to User API for user & Company API for company do not result in the issue. What does result in the issue, is attaching Companies to users as the char escape kicks in once a |
Issue appears to not be part of the Java SDK as responses using curl also contain escaped chars, but the UI does not |
Heard back from intercom support. Apparently, this is expected behaviour. See excerpt from https://developers.intercom.com/intercom-api-reference/v1.1/reference#encoding HTML Encoding
In all responses back from Intercom: name, email, user_id and company_id are HTML encoded. So if you retrieve a Company and add it to a User, you must sanitise the name & email of each before updating |
Version info
Expected behavior
We have a user with company names that has special characters in their names e.g. apostrophe or ampersands.
Updating such companies causes their name to include tons of & then fail with message name too long
Actual behavior
Steps to reproduce
The text was updated successfully, but these errors were encountered: