Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more straightforward options by type #347

Open
ota42y opened this issue Dec 28, 2021 · 0 comments
Open

Add more straightforward options by type #347

ota42y opened this issue Dec 28, 2021 · 0 comments
Labels

Comments

@ota42y
Copy link
Member

ota42y commented Dec 28, 2021

Now we support many options and committee's middleware expect these options by hash.
https://github.com/interagent/committee#committeemiddlewarerequestvalidation

I want to add Option class with type it provide typing support checking for correct values, and for internal use.

Now we have RequestValidation and ResponseValidation class, these classes based on Base class.
https://github.com/interagent/committee/tree/master/lib/committee/middleware

So our new option class should be same structure.

  • BaseOption
    • use by Base class
  • RequestValidationOption
    • use by RequestValidation class
    • user pass this object
    • (or if the user pass options by hash, committee create this class)
  • ResponseValidationOption
    • use by ResponseValidation class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant