Template review feedback

[praveena-pappu]

Thank you for submitting template to the gallery. However, there are a few issues that needs to be resolved ahead of approving the template for the gallery.

1. The url mentioned for documentation in the "manifest.yaml" file is not valid or related to intent. Please update the same.
2. Please provide a reg-exp for the "tag_url" being mentioned in the code and also please add a help text for user to understand how the "tag_url" format should look like.

[michael-elliott]

@praveena-pappu -

1. We have no specific documentation for the tag online. We provide custom documentation to all clients looking to integrate Intent on a client by client basis. Could you tell me what we should put in the documentation URL in this case?

2. Could you explain more what you require here for this regexp? The tag_url as mentioned in the help text should not be changed by the user unless specifically instructed in documentation or communication directly between the client and Intent, where we may want them to implement a specific file name at the end of the URL instead of intent_media_core.js, so that we can adapt the code for their uses.

[michael-elliott]

tagging @doudl for while I'm on vacation.

[delsonting]

1. The documentation field is optional, if you don't have online docs you can remove the field in https://github.com/intentmedia/intent-gtm-template/blob/master/metadata.yaml

2. For each field in the template you can include a validation rule such that incorrect values entered by users can be detected during setup. The recommendation here is to include validation to constrain the possible urls provided. If the only thing a user changes is the file name, you can add a validation rule that uses regex to verify that the file name has the right format. My regex is not great, but it sounds like you want something along the lines of:
   ^https:\/\/a.cdn.intentmedia.net\/javascripts\/v1\/ (please verify before using)

[michael-elliott]

@delsonting - apologies for the delay, was on vacation. I have made the changes per above. Let me know when it's pushed or if there are other requests.

[delsonting]

Thanks, template has been approved and should appear in the gallery within 24 hours.