Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Performance Thresholds to Test Runner #36

Merged
merged 28 commits into from
Jun 6, 2024
Merged

Add Performance Thresholds to Test Runner #36

merged 28 commits into from
Jun 6, 2024

Conversation

tylertitsworth
Copy link
Contributor

Description

Add Performance Thresholds from an internal repository for NDA products/services.

Related Issue

MLOPS-1968

@tylertitsworth tylertitsworth self-assigned this May 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

test-runner/requirements.txt

PackageVersionLicenseIssue Type
Pint>= 0.21.1NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
pip/Pint >= 0.21.1 🟢 5.5
Details
CheckScoreReason
Code-Review🟢 4Found 14/30 approved changesets -- score normalized to 4
Maintained🟢 1030 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Packaging🟢 10packaging workflow detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/gitpython >= 3.1.43 🟢 7.9
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1030 commit(s) and 17 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing🟢 10project is fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
SAST🟢 10SAST tool is run on all commits

Scanned Manifest Files

test-runner/dev-requirements.txt
  • Pint@>= 0.21.1
  • gitpython@>= 3.1.43
test-runner/requirements.txt
  • Pint@>= 0.21.1
  • gitpython@>= 3.1.43

@tylertitsworth tylertitsworth changed the base branch from v0.4.0-Beta to main May 28, 2024 15:56
@tylertitsworth tylertitsworth added the WIP Work in Progress label May 28, 2024
@tylertitsworth tylertitsworth changed the base branch from main to tylertitsworth/perf-repo-infra June 4, 2024 16:03
@tylertitsworth tylertitsworth force-pushed the tylertitsworth/perf-thresholds branch from 215a097 to 839cfd0 Compare June 4, 2024 16:06
Base automatically changed from tylertitsworth/perf-repo-infra to main June 4, 2024 16:35
@tylertitsworth tylertitsworth force-pushed the tylertitsworth/perf-thresholds branch from f8d5295 to 72e5505 Compare June 4, 2024 20:22
@tylertitsworth tylertitsworth force-pushed the tylertitsworth/perf-thresholds branch from 72e5505 to 72f5a49 Compare June 4, 2024 20:26
@tylertitsworth tylertitsworth added Review and removed WIP Work in Progress labels Jun 5, 2024
claynerobison
claynerobison previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@claynerobison claynerobison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylertitsworth tylertitsworth force-pushed the tylertitsworth/perf-thresholds branch from c19d903 to 6282304 Compare June 6, 2024 15:41
@tylertitsworth tylertitsworth added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 5db8ff7 Jun 6, 2024
16 checks passed
@tylertitsworth tylertitsworth deleted the tylertitsworth/perf-thresholds branch June 7, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendra42 jitendra42 jitendra42 approved these changes

@claynerobison claynerobison claynerobison left review comments

Assignees

@tylertitsworth tylertitsworth

Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylertitsworth @jitendra42 @claynerobison