Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add suppurt for using github apps with resource "github_team_sync_group_mapping" #2395

Open
1 task done
noahg1 opened this issue Sep 20, 2024 · 2 comments
Open
1 task done
Labels
Type: Feature New feature or request

Comments

@noahg1
Copy link

noahg1 commented Sep 20, 2024

Describe the need

Currently the resource "github_team_sync_group_mapping" uses an endpoint that is not compatible with GitHub app tokens. We need to use a GitHub app token to avoid being rate limited by GitHub. This endpoint allows use with a GitHub app token. It would be awesome if there was a way to use the endpoint that is compatible with GitHub apps within the "github_team_sync_group_mapping" resource.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@noahg1 noahg1 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Sep 20, 2024
@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Sep 27, 2024
@kfcampbell
Copy link
Member

Hmm...would that work? They're different API routes and I thought they performed different functions. Reading the docs now, though, I'm not sure I understand the difference (apart from the obvious that you've linked one endpoint that lists groups for a team and one that lists groups for an org).

@noahg1
Copy link
Author

noahg1 commented Oct 2, 2024

My initial thoughts were that the Org level endpoint was geared more towards enterprise customers. If we have these IdP groups set at our Org level I would think we could use them to sync our GitHub teams. Maybe an additional parameter in the resource org_level = boolean ? Happy to get your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants