Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Support targeting dynamic list by properties in organizational rulesets #2137

Open
1 task done
jinkang23 opened this issue Feb 9, 2024 · 4 comments · May be fixed by #2356
Open
1 task done

[FEAT]: Support targeting dynamic list by properties in organizational rulesets #2137

jinkang23 opened this issue Feb 9, 2024 · 4 comments · May be fixed by #2356
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@jinkang23
Copy link

Describe the need

GitHub Rest API Create an organization repository ruleset recently added support in conditions parameter to also target dynamic list by custom properties (i.e. conditions.repository_property_and_ref_name).

I'm asking to add support for this in GitHub terraform resource github_organization_ruleset.
Can this support be added to the next release version? Thank you!

Here's an example of what I'm asking.

resource "github_organization_ruleset" "example" {
  name        = "example"
  target      = "branch"
  enforcement = "active"

  conditions {
    ref_name {
      include = ["~ALL"]
      exclude = []
    }

    # add new `repository_property` nested block under `conditions` block
    repository_property {
      include = ["custom-prop1","custom-prop2"]
      exclude = []
    }

  }
...
}

SDK Version

No response

API Version

2022-11-28

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jinkang23 jinkang23 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Feb 9, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Feb 12, 2024
@YElyousfi
Copy link

Hello, I am also looking for the same functionality. Any shot this can be tackled for an upcoming release?

@MariusStorhaug
Copy link

To add to the desired interface, think the type should resemble that of the UI?

Property name, property value.

@Moser-ss
Copy link
Contributor

Moser-ss commented Sep 7, 2024

The PR #2356 add support to use the custom properties to target repositories in a ruleset

@PaarthShah
Copy link

I'd also like to see this implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
6 participants