Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep batches/samples information if there is an error creating box #1943

Open
leandroradusky opened this issue May 25, 2023 — with Manas.Tech Commit · 1 comment
Open

Comments

Copy link
Contributor

leandroradusky commented May 25, 2023

When creating a new box, in select existing samples mode or upload CSV mode if there is an error in the form (for example if the user doesn't select a purpose or a media) the information about the samples is lost. This provokes that the user needs to define all the information about the batches/samples again, from scratch.

Before saving:
image

After saving:
image

This does not happen in select samples from inventory mode, where the information is correctly kept.

We should keep the information of the work done in the form in these other two modes as well.

@ysbaddaden
Copy link
Contributor

ysbaddaden commented May 30, 2023

@leandroradusky @devduarte That's a bug. It was implemented. Looking at boxes/_form.haml we do pass @box_form.samples_data to the SamplesSelector React component that does render all the samples it receives in this.props.samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants