Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to enter replicates with zero concentration #1901

Closed
diegoliberman opened this issue Feb 7, 2023 — with Manas.Tech Commit · 3 comments · Fixed by #1908
Closed

Allow to enter replicates with zero concentration #1901

diegoliberman opened this issue Feb 7, 2023 — with Manas.Tech Commit · 3 comments · Fixed by #1908
Assignees
@leandroradusky

Comments

@diegoliberman Manas.Tech Commit
Copy link
Contributor

diegoliberman commented Feb 7, 2023 •
edited
Loading

image

BONUS

  1. Reduce the space to enter the number of replicates, so that we gain space for increasing the field for defining the concentration. See this image:

image

  1. Move the instructions label to the line below, closer to the input field

image
@leandroradusky leandroradusky mentioned this issue Feb 8, 2023
Merged
@sardar-usman
Copy link

@leandroradusky The 'INSTRUCTIONS' label is not close to input field. @diegoliberman
Screenshot 2023-02-10 at 3 09 52 PM

@diegoliberman
Copy link
Contributor Author

@sardar-usman good catch! I decided that those details will be fixed in #1909. If you find more, please add a comment into that issue. Thanks!

@ysbaddaden
Copy link
Contributor

@sardar-usman @diegoliberman I extracted the whitespace fix bonus to #1909, so we can move this issue to verified (the bug is fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandroradusky leandroradusky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to enter zero concentration in boxes creation instedd/cdx
4 participants
@ysbaddaden @leandroradusky @diegoliberman @sardar-usman