You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the pre-commit hook no longer works, making it possible to commit code that does not pass pre-commit checks:
[killy@skynet : /dane/projekty/binarapps/trustless-sidechain] git add .
[killy@skynet : /dane/projekty/binarapps/trustless-sidechain] git commit
Aborting commit due to empty commit message.
[killy@skynet : /dane/projekty/binarapps/trustless-sidechain] make format-staged
Creating a git commit object to snapshot the current staged files...
21cefd4fd7e39ab7cb66bf0d47d5fac1008adc19
Formatting `*.hs`...
Loaded config from: /dane/projekty/binarapps/trustless-sidechain/fourmolu.yaml
Formatting `*.cabal`...
Formatting whitespace...
Formatting `*.purs`...
Formatting `*.js`...
Formatting `*.dhall`...
Formatting `*.nix` files...
[killy@skynet : /dane/projekty/binarapps/trustless-sidechain] git st
On branch ETCM-7669-implement-modular-governance
Your branch is ahead of 'origin/ETCM-7669-implement-modular-governance' by 1 commit.
(use "git push" to publish your local commits)
Changes to be committed:
(use "git restore --staged <file>..." to unstage)
modified: onchain/src/TrustlessSidechain/DParameter.hs
modified: onchain/src/TrustlessSidechain/Governance/Admin.hs
modified: onchain/src/TrustlessSidechain/PermissionedCandidates.hs
modified: onchain/src/TrustlessSidechain/Reserve.hs
modified: onchain/src/TrustlessSidechain/Versioning.hs
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: onchain/src/TrustlessSidechain/DParameter.hs
modified: onchain/src/TrustlessSidechain/PermissionedCandidates.hs
modified: onchain/src/TrustlessSidechain/Versioning.hs
Had I not aborted the commit, I would be able to commit incorrectly formatted files, as witnessed by the fact that make format-stagged re-formatted some of the staged files.
Ok, I think we might have actually disabled this on purpose since the new version of the formatter (formoulu?) uses different layout rules, resulting in lots of unnecessary reformatting being done to the code.
It seems that the pre-commit hook no longer works, making it possible to commit code that does not pass pre-commit checks:
Had I not aborted the commit, I would be able to commit incorrectly formatted files, as witnessed by the fact that
make format-stagged
re-formatted some of the staged files.IOG Jira: https://input-output.atlassian.net/browse/ETCM-7677
The text was updated successfully, but these errors were encountered: