From 27ced38e8ec92e96a93d8a4f631deb155433d35a Mon Sep 17 00:00:00 2001
From: Shay Bergmann <shay.bergmann@iohk.io>
Date: Fri, 24 May 2019 14:18:07 -0400
Subject: [PATCH] gac: split `deployments/configurator.nix`

into `deployments/gac/{configurator,common-aws}.nix`.

To maintain backward-compatibility I put a placeholder in the original
path (`deployments/configurator.nix`) that `require`s the two new files
and emits a deprecation warning.

This is generally needed for supporting providers other than AWS.

Fixes #599
---
 deployments/configurator.nix     | 45 ++++----------------------------
 deployments/gac/common-aws.nix   | 21 +++++++++++++++
 deployments/gac/configurator.nix | 19 ++++++++++++++
 3 files changed, 45 insertions(+), 40 deletions(-)
 create mode 100644 deployments/gac/common-aws.nix
 create mode 100644 deployments/gac/configurator.nix

diff --git a/deployments/configurator.nix b/deployments/configurator.nix
index 86f733a7f4d..606a113acea 100644
--- a/deployments/configurator.nix
+++ b/deployments/configurator.nix
@@ -1,41 +1,6 @@
-{ accessKeyId
-, deployerIP
-, config
-, ...
-}:
-with (import <nixpkgs> {}).lib;
-{
-  ## Per-machine defaults:
-  defaults = {
-    # For Nixops configs, the `config` object we constructed in `/config.nix` should be sufficient;
-    # for NixOS configs however, we need to make a distinction between defaults and and user-supplied parameters.
-    imports = [ <module/configurator.nix> ];
-
-    # The configurator *module* basically just changes the precedence of everything in `optionDefaults` and `userConfig` and merges them
-    # together. The reason we have to send it off to a NixOS module is because we literally can't do it here in nixops. Trust, I tried. There be dragons and hydrae 🐉🐲.
-    configurator = {
-      # So yeah `config` already has both defaults and user-defined parameters but we can't tell which is which
-      optionDefaults = config;
-      # So we also pass the bare user config so that we can work the magic of set theory (I think?)
-      userConfig     = import <config>;
-    };
-  };
-
-  ## Universal resource logic:
-  resources.ec2KeyPairs."cardano-keypair-${config.node.org}-${config.node.region}" = {
-    inherit accessKeyId; inherit (config.node) region;
-  };
-
-  resources.ec2SecurityGroups = {
-    "allow-deployer-ssh-${config.node.region}-${config.node.org}" = {
-      _file = ./configurator.nix;
-      inherit accessKeyId; inherit (config.node) region;
-      description = "SSH";
-      rules = [{
-        protocol = "tcp"; # TCP
-        fromPort = 22; toPort = 22;
-        sourceIp = deployerIP + "/32";
-      }];
-    };
-  };
+builtins.trace "[WARN] deployments/configurator.nix has been split into deployments/gac/configurator.nix and deployments/gac/common-aws.nix please update your symlinks" {
+  require = [
+    ./gac/configurator.nix
+    ./gac/common-aws.nix
+  ];
 }
diff --git a/deployments/gac/common-aws.nix b/deployments/gac/common-aws.nix
new file mode 100644
index 00000000000..d2292fe6101
--- /dev/null
+++ b/deployments/gac/common-aws.nix
@@ -0,0 +1,21 @@
+{ config, ... }:
+
+{
+  ## Universal resource logic:
+  resources.ec2KeyPairs."cardano-keypair-${config.node.org}-${config.node.region}" = {
+    inherit (config.node) region accessKeyId;
+  };
+
+  resources.ec2SecurityGroups = {
+    "allow-deployer-ssh-${config.node.region}-${config.node.org}" = {
+      _file = ./configurator.nix;
+      inherit (config.node) region accessKeyId;
+      description = "SSH";
+      rules = [{
+        protocol = "tcp"; # TCP
+        fromPort = 22; toPort = 22;
+        sourceIp = config.cluster.deployerIP + "/32";
+      }];
+    };
+  };
+}
diff --git a/deployments/gac/configurator.nix b/deployments/gac/configurator.nix
new file mode 100644
index 00000000000..d75a0ef1414
--- /dev/null
+++ b/deployments/gac/configurator.nix
@@ -0,0 +1,19 @@
+{ config , ...  }:
+
+{
+  ## Per-machine defaults:
+  defaults = {
+    # For Nixops configs, the `config` object we constructed in `/config.nix` should be sufficient;
+    # for NixOS configs however, we need to make a distinction between defaults and and user-supplied parameters.
+    imports = [ <module/configurator.nix> ];
+
+    # The configurator *module* basically just changes the precedence of everything in `optionDefaults` and `userConfig` and merges them
+    # together. The reason we have to send it off to a NixOS module is because we literally can't do it here in nixops. Trust, I tried. There be dragons and hydrae 🐉🐲.
+    configurator = {
+      # So yeah `config` already has both defaults and user-defined parameters but we can't tell which is which
+      optionDefaults = config;
+      # So we also pass the bare user config so that we can work the magic of set theory (I think?)
+      userConfig     = import <config>;
+    };
+  };
+}