This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
gac: split deployments/configurator.nix
#601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaii-zen
requested review from
cleverca22,
disassembler,
jbgi,
johnalotoski and
deepfire
cleverca22
reviewed
May 25, 2019
cleverca22
reviewed
May 25, 2019
| }; | ||
|
|
||
| resources.ec2SecurityGroups = { | ||
| "allow-deployer-ssh-${config.node.region}-${config.node.org}" = { |
There was a problem hiding this comment.
with the latest changes in the master branch, you can also do:
require = [ ./security-groups/allow-deployer-ssh.nix ];
but that relies on io having done nixops set-args --arg globals 'import ./globals.nix ....'
There was a problem hiding this comment.
We could do some gymnastics to get around io's globals but wouldn't it just make things more difficult to reason about? @deepfire thoughts?
into `deployments/gac/{configurator,common-aws}.nix`.
To maintain backward-compatibility I put a placeholder in the original
path (`deployments/configurator.nix`) that `require`s the two new files
and emits a deprecation warning.
This is generally needed for supporting providers other than AWS.
Fixes #599
kaii-zen
force-pushed
the
krs-configurator-split
branch
from
336b125
to
27ced38
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into
deployments/gac/{configurator,common-aws}.nix.To maintain backward-compatibility I put a placeholder in the original
path (
deployments/configurator.nix) thatrequires the two new filesand emits a deprecation warning.
This is generally needed for supporting providers other than AWS.
Fixes #599