Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

gac: deployments/configurator.nix has AWS-specific code in it #599

Open
kaii-zen opened this issue May 24, 2019 · 0 comments
Open

gac: deployments/configurator.nix has AWS-specific code in it #599

kaii-zen opened this issue May 24, 2019 · 0 comments
Assignees
Labels

Comments

@kaii-zen
Copy link
Contributor

This file is used by all GAC-based deployments for the purpose of sharing
configuration parameters between NixOS VMs/instances and the Nixops configs that
deploy them. It also contains some definitions of AWS resources. While the
configuration-parameter management aspect of it is needed by all GAC
deployments, the AWS resources are only needed by deployments to AWS instances.
We therefore need to be able to include those parts separately.

@kaii-zen kaii-zen added the bug label May 24, 2019
@kaii-zen kaii-zen self-assigned this May 24, 2019
kaii-zen pushed a commit that referenced this issue May 24, 2019
into `deployments/gac/{configurator,common-aws}.nix`.

To maintain backward-compatibility I put a placeholder in the original
path (`deployments/configurator.nix`) that `require`s the two new files
and emits a deprecation warning.

This is generally needed for supporting providers other than AWS.

Fixes #599
kaii-zen pushed a commit that referenced this issue May 30, 2019
into `deployments/gac/{configurator,common-aws}.nix`.

To maintain backward-compatibility I put a placeholder in the original
path (`deployments/configurator.nix`) that `require`s the two new files
and emits a deprecation warning.

This is generally needed for supporting providers other than AWS.

Fixes #599
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant