Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe don't auto-generate keys? #22

Open
michaelpj opened this issue Nov 1, 2022 · 4 comments
Open

Maybe don't auto-generate keys? #22

michaelpj opened this issue Nov 1, 2022 · 4 comments

Comments

@michaelpj
Copy link
Collaborator

Given that

  1. There is a command to create keys
  2. There is a way to build without keys
  3. Building with a freshly created set of keys is rarely what you want

I think it would be reasonable to not automatically generate keys. It mostly makes it easier to do 3 by accident, which is rarely what you want.

@michaelpj
Copy link
Collaborator Author

Brainstorming: perhaps we should flip the polarity and not sign by default, unless you explicitly say to do so.

Then we'd want a way to prevent people from forgetting, maybe we want a repo.toml in the root that specifies whether the repo is supposed to be secure or not. Then it's all very explicit.

@andreabedini
Copy link
Member

perhaps we should flip the polarity and not sign by default, unless you explicitly say to do so.

I think this is a good idea. To be fair, I thought signatures were required when I first started working on this.

@andreabedini
Copy link
Member

@michaelpj see #23

@bgamari
Copy link
Collaborator

bgamari commented Mar 21, 2023

Yes, I agree that automatic key generation should not be enabled by default. This behavior has lead to some very surprising bugs in my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants