From ba1a61345e989660b255c0fadd2f481e7d373c01 Mon Sep 17 00:00:00 2001
From: Manuel Ung <mung@meta.com>
Date: Fri, 14 Oct 2022 13:02:07 -0700
Subject: [PATCH] Fix rocksdb_sys_vars.all_vars

Upstream commit ID: https://github.com/facebook/mysql-5.6/commit/a4007575e9634bedbed8ff52aecc89adda741fac
PS-8494: Merge percona-202206 (https://jira.percona.com/browse/PS-8494)

Summary:
Add some missing tests. Looks like somebody else (D39971029) has
mistakenly re-recorded the test in the meantime.

Squash with: D40196622 , D39971029

Reviewed By: hermanlee

Differential Revision: D40394659

fbshipit-source-id: c840bc2616a4cd577db03f512e4b0eb14e928d43
---
 ...db_partial_index_blind_delete_basic.result | 75 +++++++++++++++++++
 ...ksdb_partial_index_blind_delete_basic.test | 20 +++++
 2 files changed, 95 insertions(+)
 create mode 100644 mysql-test/suite/rocksdb_sys_vars/r/rocksdb_partial_index_blind_delete_basic.result
 create mode 100644 mysql-test/suite/rocksdb_sys_vars/t/rocksdb_partial_index_blind_delete_basic.test

diff --git a/mysql-test/suite/rocksdb_sys_vars/r/rocksdb_partial_index_blind_delete_basic.result b/mysql-test/suite/rocksdb_sys_vars/r/rocksdb_partial_index_blind_delete_basic.result
new file mode 100644
index 000000000000..2c07380e4d97
--- /dev/null
+++ b/mysql-test/suite/rocksdb_sys_vars/r/rocksdb_partial_index_blind_delete_basic.result
@@ -0,0 +1,75 @@
+CREATE TABLE valid_values (value varchar(255)) ENGINE=myisam;
+INSERT INTO valid_values VALUES(1);
+INSERT INTO valid_values VALUES(0);
+INSERT INTO valid_values VALUES('on');
+INSERT INTO valid_values VALUES('off');
+CREATE TABLE invalid_values (value varchar(255)) ENGINE=myisam;
+INSERT INTO invalid_values VALUES('\'aaa\'');
+INSERT INTO invalid_values VALUES('\'bbb\'');
+SET @start_global_value = @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+SELECT @start_global_value;
+@start_global_value
+1
+'# Setting to valid values in global scope#'
+"Trying to set variable @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to 1"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = 1;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Setting the global scope variable back to default"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE = DEFAULT;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Trying to set variable @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to 0"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = 0;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+0
+"Setting the global scope variable back to default"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE = DEFAULT;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Trying to set variable @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to on"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = on;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Setting the global scope variable back to default"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE = DEFAULT;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Trying to set variable @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to off"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = off;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+0
+"Setting the global scope variable back to default"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE = DEFAULT;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Trying to set variable @@session.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to 444. It should fail because it is not session."
+SET @@session.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = 444;
+ERROR HY000: Variable 'rocksdb_partial_index_blind_delete' is a GLOBAL variable and should be set with SET GLOBAL
+'# Testing with invalid values in global scope #'
+"Trying to set variable @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to 'aaa'"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = 'aaa';
+Got one of the listed errors
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+"Trying to set variable @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE to 'bbb'"
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE   = 'bbb';
+Got one of the listed errors
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+SET @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE = @start_global_value;
+SELECT @@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE;
+@@global.ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+1
+DROP TABLE valid_values;
+DROP TABLE invalid_values;
diff --git a/mysql-test/suite/rocksdb_sys_vars/t/rocksdb_partial_index_blind_delete_basic.test b/mysql-test/suite/rocksdb_sys_vars/t/rocksdb_partial_index_blind_delete_basic.test
new file mode 100644
index 000000000000..dc27cd03f6d4
--- /dev/null
+++ b/mysql-test/suite/rocksdb_sys_vars/t/rocksdb_partial_index_blind_delete_basic.test
@@ -0,0 +1,20 @@
+--source include/have_rocksdb.inc
+
+CREATE TABLE valid_values (value varchar(255)) ENGINE=myisam;
+INSERT INTO valid_values VALUES(1);
+INSERT INTO valid_values VALUES(0);
+INSERT INTO valid_values VALUES('on');
+INSERT INTO valid_values VALUES('off');
+
+CREATE TABLE invalid_values (value varchar(255)) ENGINE=myisam;
+INSERT INTO invalid_values VALUES('\'aaa\'');
+INSERT INTO invalid_values VALUES('\'bbb\'');
+
+--let $sys_var=ROCKSDB_PARTIAL_INDEX_BLIND_DELETE
+--let $read_only=0
+--let $session=0
+--let $sticky=1
+--source ../include/rocksdb_sys_var.inc
+
+DROP TABLE valid_values;
+DROP TABLE invalid_values;