-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS20 v2 Protobuf encoding #4098
Comments
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
ICS20 v2 will encode packet data using Protobuf instead of JSON cosmos/ibc-go#6630.
Hermes will need to adapt the verification of memo and receiver fields to decode using Protobuf if the transfer is from ICS20 v2, https://github.com/informalsystems/hermes/blob/v1.10.0/crates/relayer/src/link/relay_path.rs#L1956.
Furthermore if the packet is a forward packet, the
destination_memo
, https://github.com/cosmos/ibc-go/blob/v9.0.0-beta.0/proto/ibc/applications/transfer/v2/packet.proto#L48, should be checked. If not the standardmemo
should be checked, https://github.com/cosmos/ibc-go/blob/v9.0.0-beta.0/proto/ibc/applications/transfer/v2/packet.proto#L38.For Admin Use
The text was updated successfully, but these errors were encountered: