Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus: Unsigned float #15909

Open
nischu opened this issue Sep 17, 2024 · 1 comment
Open

Modbus: Unsigned float #15909

nischu opened this issue Sep 17, 2024 · 1 comment
Labels
area/modbus feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue

Comments

@nischu
Copy link

nischu commented Sep 17, 2024

Use Case

I am using power meters that provide measurement values using a Non-IEEE floating point formats:

Unsigned Measurement (32 bit):

  • Decade Exponent(Signed 8 bit)
  • Binary Unsigned Value (24 bit)
    Example: 123456*10–3 stored as FD01 E240(16)

Signed Measurement (32 bit)

  • Decade Exponent (Signed 8 bit)
  • Binary Signed value (24 bit)
    Example: - 123456*10–3 stored as FDFE 1DC0(16)

I am looking for a way to configure/extend the modbus input plugin to handle these values.

Am I right that currently, only IEEE (signed) float values are supported? Can I just come up with new data_types like UFLOAT32 and MSIGN_FLOAT32 (as the mantissa holds the sign)?

I'd be able to implement it on my own, just checking what a sane convention would be.

Kind regards

nischu

Expected behavior

I would like the Modbus input plugin to generate correct floating point values

Actual behavior

I cannot really specify this custom data type

Additional info

https://cdn.findernet.com/app/uploads/Benutzerhandbuch_Typ_7M38_DE.pdf page 52

@nischu nischu added the feature request Requests for new plugin and for new features to existing plugins label Sep 17, 2024
@srebhan
Copy link
Member

srebhan commented Oct 2, 2024

From my perspective we can add these strange types if we do find a clear and unique name for those like Finder_T5_Float32 with good description of the layout and a link to the definition document.

Would you be able and willing to put up a PR?

@srebhan srebhan added help wanted Request for community participation, code, contribution area/modbus size/s 1 day effort, great beginniner issue labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue
Projects
None yet
Development

No branches or pull requests

2 participants