Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets with no secret store references should behave like plain strings #13807

Closed
redbaron opened this issue Aug 21, 2023 · 1 comment · Fixed by #13998
Closed

secrets with no secret store references should behave like plain strings #13807

redbaron opened this issue Aug 21, 2023 · 1 comment · Fixed by #13998
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@redbaron
Copy link
Contributor

Use Case

secretstore memguard is quite complicated, but it is invoked every time "secret-capable" config option is accessed even if there is no references to a secret store.

There is no value in "protecting" what essentially a plaintext string.

Expected behavior

config parameters with no secret store references should be short-circuit to a plaintext string, skipping memguard completely.

Actual behavior

memguard is used every time config parameter with potential secret in it is accessed, even if there is no references to secret stores.

Additional info

Memguard can be quite challenging to deal with: #13804, #13806. Skipping it entirely when it doesn't add any value simplifies telegraf setup.

@redbaron redbaron added the feature request Requests for new plugin and for new features to existing plugins label Aug 21, 2023
@powersj
Copy link
Contributor

powersj commented Aug 28, 2023

next steps: similar to #13804, want to get on the same page with Sven and go through each of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
2 participants