Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop enums for Study, Biospecimen, Data File, Assay and add ontology terms #108

Open
12 tasks
Tracked by #54
lopierra opened this issue Feb 14, 2023 · 3 comments
Open
12 tasks
Tracked by #54

Comments

@lopierra
Copy link
Member

lopierra commented Feb 14, 2023

Add/review/finalize enums/ontology terms for the following Study/Dataset fields (see notes here):


Pierrette's comments:
For Biospecimen/Assay/DataFile, we have discussed EDAM, OBI, etc. Sample Type, File Type, etc.

Currently, we have a controlled vocabulary, but using a pre-existing ontology might allow us to have more relationships/hierarchies, e.g., between Data Categories & Types. Maybe we could annotate Experimental Platform and then have a search widget for users to search parent categories?

@lopierra lopierra changed the title All - Determine enums/vocab for the various fields (have discussed EDAM, OBI, etc.) Assay - add ontology terms for enums (have discussed EDAM, OBI, etc.) Feb 14, 2023
@lopierra lopierra changed the title Assay - add ontology terms for enums (have discussed EDAM, OBI, etc.) Add more ontology terms for enums Feb 14, 2023
@lopierra lopierra self-assigned this Feb 14, 2023
@lopierra lopierra changed the title Add more ontology terms for enums Develop enums for Biospecimen, Data File, Assay and add ontology terms Feb 14, 2023
@lopierra lopierra assigned twhetzel and unassigned lopierra Mar 1, 2024
@lopierra lopierra added the Study label Mar 1, 2024
@lopierra
Copy link
Member Author

lopierra commented Mar 1, 2024

Application ontology will also be very useful for the new Study/Datatset fields. Please see the yellow highlighted cells in this sheet.

@lopierra
Copy link
Member Author

lopierra commented Mar 1, 2024

Related to #159

@twhetzel
Copy link

twhetzel commented Mar 5, 2024

Matt and I have discussed two options for including enums from ontology terms, (1) an explicit enumeration of terms in enum definitions or (2) referencing subsets of terms defined in an external Application Ontology.

Currently the decision is for (1) to define a fixed set of terms in the schema in advance because the LinkML docs says "this works well if the vocabulary is known in advance and it is a relatively small number of terms" [1].

A small example for sample type is in this branch

The notes from our discussion are in the INCLUDE gDrive here.

Two open questions are:

  • Does the model have a display name field to customize the values?
  • Can values be represented as a hierarchy?

[1] https://linkml.io/linkml/faq/modeling.html#how-do-i-constrain-the-value-of-a-slot-using-an-ontology-or-vocabulary

@lopierra lopierra changed the title Develop enums for Biospecimen, Data File, Assay and add ontology terms Develop enums for Study, Biospecimen, Data File, Assay and add ontology terms Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants