Rework code in SBLED so LED information is in the platform

[mithro]

Currently the SBLED has the following horrible hack;

foboot/hw/foboot-bitstream.py

Lines 343 to 360 in a4a3dad

	if revision == "pvt" or revision == "evt" or revision == "dvt":
	self.comb += [
	If(self.ctrl.storage[3], rgba_pwm[1].eq(self.raw.storage[0])).Else(rgba_pwm[1].eq(ledd_value[0])),
	If(self.ctrl.storage[4], rgba_pwm[0].eq(self.raw.storage[1])).Else(rgba_pwm[0].eq(ledd_value[1])),
	If(self.ctrl.storage[5], rgba_pwm[2].eq(self.raw.storage[2])).Else(rgba_pwm[2].eq(ledd_value[2])),
	]
	elif revision == "hacker":
	self.comb += [
	If(self.ctrl.storage[3], rgba_pwm[2].eq(self.raw.storage[0])).Else(rgba_pwm[2].eq(ledd_value[0])),
	If(self.ctrl.storage[4], rgba_pwm[1].eq(self.raw.storage[1])).Else(rgba_pwm[1].eq(ledd_value[1])),
	If(self.ctrl.storage[5], rgba_pwm[0].eq(self.raw.storage[2])).Else(rgba_pwm[0].eq(ledd_value[2])),
	]
	else:
	self.comb += [
	If(self.ctrl.storage[3], rgba_pwm[0].eq(self.raw.storage[0])).Else(rgba_pwm[0].eq(ledd_value[0])),
	If(self.ctrl.storage[4], rgba_pwm[1].eq(self.raw.storage[1])).Else(rgba_pwm[1].eq(ledd_value[1])),
	If(self.ctrl.storage[5], rgba_pwm[2].eq(self.raw.storage[2])).Else(rgba_pwm[2].eq(ledd_value[2])),
	]

What should be done is that the "platform" should define the RGB and rgb0/rgb1/rgb2 relationship and the SBLED should just ask which one is the red/green/blue.

[mithro]

Important information seems to be....

    rgb_write(r, LEDDPWRG); // Red
    rgb_write(g, LEDDPWRB); // Green
    rgb_write(b, LEDDPWRR); // Blue

            o_PWMOUT0 = ledd_value[0],
            o_PWMOUT1 = ledd_value[1],
            o_PWMOUT2 = ledd_value[2],

RGB0
Open-drain output of the RGB Driver connected to the device pin for RED LED
RGB1
Open-drain output of the RGB Driver connected to the device pin for GREEN LED
RGB2
Open-drain output of the RGB Driver connected to the device pin for BLUE LED

0001 LEDDPWRR LED Driver Pulse Width Register for RED W
0010 LEDDPWRG LED Driver Pulse Width Register for GREEN W
0011 LEDDPWRB LED Driver Pulse Width Register for BLUE W

[xobs]

It's slightly more complicated than that because of how the SB_RGBA_DRV is implimented. The blackbox has three outputs: RGB0, RGB1, and RGB2. These cannot be remapped, so unlike other implementations where we can just refer to them with platform.request() we actually have to manually place muxes in front of them.

[mithro]

Your doing the remapping between the SB_LEDDA_IP PWM outputs and the SB_RGBA_DRV inputs if I understand correctly?

[xobs]

It's remapping both the SB_LEDDA_IP PWM outputs and some optional bit-banged outputs. The raw registers allow for letting C code directly control the registers by disengaging the SB_LEDDA_IP.

[mithro]

Something like;

rgba_drv_pins = {
 'pin 1': 'RGB0',
 'pin 2': 'RGB1',
 'pin 3': 'RGB2',
}

r_led = platform.request('user_led_r')
self.comb += [
  If(csr.storage[RED], platform.get_pin(rgba_drv_pins[r_led.pin]).eq(ledda_ip.pwmout0), ...)
]
g_led = platform.request('user_led_g')
self.comb += [
  platform.get_pin(rgba_drv_pins[g_led.pin]).eq(ledda_ip.pwmout1),
]

b_led = platform.request('user_led_b')
self.comb += [
  platform.get_pin(rgba_drv_pins[b_led.pin]).eq(ledda_ip.pwmout1),
]