Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot_product in your code #1

Open
ghost opened this issue Feb 18, 2023 · 1 comment
Open

dot_product in your code #1

ghost opened this issue Feb 18, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 18, 2023

Dear ifsheldon,

I would like to start by thanking you for creating legible MPL repo. Your work has been invaluable in advancing the field of computer vision, and I am truly grateful for your contributions.
I am writing to ask you one question about dot_product in your code:
image
But in official implementation of MPL, h is computed by:
image
which means h = L_S_new - L_S_old
And this is my writing of h:
image
Seem like we have the same idea. But why is it different from author's ?
If you figured it out, please inform me. Thank you so much.

@ifsheldon
Copy link
Owner

yeah....... Things get awkward. See here from MPL-PyTorch and its related issue. According to this issue, it turns out the MPL does not matter much.

Repository owner deleted a comment from fede-s Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant