Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add skew and kurtosis to subdomainTimeDepStats test #2362

Open
10 tasks
joshua-cogliati-inl opened this issue Sep 9, 2024 · 1 comment
Open
10 tasks
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment

Comments

@joshua-cogliati-inl
Copy link
Contributor


Issue Description

In: tests/framework/PostProcessors/SubdomainBasicStatistics/time_dep_subdomain.xml the sample size is too small to use it for skew and kurtosis, so different samples need to be created and then the skew and kurtosis can be calculated.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@joshua-cogliati-inl joshua-cogliati-inl added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Sep 9, 2024
@joshua-cogliati-inl
Copy link
Contributor Author

Note that __computeUnbiasedCorrection should probably check for too few samples as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

No branches or pull requests

1 participant