Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly-created apps cannot add custom action syntax #28830

Open
jessecarterMOOSE opened this issue Oct 11, 2024 · 0 comments · May be fixed by #28831
Open

Newly-created apps cannot add custom action syntax #28830

jessecarterMOOSE opened this issue Oct 11, 2024 · 0 comments · May be fixed by #28831
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@jessecarterMOOSE
Copy link
Contributor

Bug Description

The registerSyntax macro (and possibly others) use the "syntax" variable name, but the registerAll() function in a new stork-created app's constructor (src/base/<AppName>App.C) uses the local variable "s". Workaround for now is to add auto & syntax = s; before registering.

@GiudGiud From discussion in #28826

Steps to Reproduce

Create a new app from stork.sh and add custom syntax like registerSyntax("MyAction", "SyntaxString");

Impact

More of an annoyance since there is a workaround

[Optional] Diagnostics

No response
@jessecarterMOOSE jessecarterMOOSE added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Oct 11, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 11, 2024
@GiudGiud
Use syntax for variable name in new apps registerSyntax to have const…
6799861 
…istency with syntax registration macro

closes idaholab#28830
@GiudGiud GiudGiud linked a pull request Oct 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
1 participant
@jessecarterMOOSE