Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Updates to NodeT type #381

Open
DnOberon opened this issue Sep 23, 2024 · 0 comments
Open

Possible Updates to NodeT type #381

DnOberon opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request low priority needs broken down question Further information is requested

Comments

@DnOberon
Copy link
Collaborator

Reason

I'm interested in a standard naming convention for nodes in DeepLynx.

Right now to display a node via some human readable string, like in a select component, you need to stringify all of its properties, like this

image

This is my only known solution because even if a node has a properties.name, TypeScript doesn't respect it

image

This is true even if I add the generic {[key: string]: string} type to the properties field on the node type

image

Design

I don't have a proposed design because I don't have an understanding of how a type change / naming convention would impact the rest of the codebase

Impact

Better UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority needs broken down question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant