Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow configuration for auto linking social account and local account for google provider #630

Open
ShadowChaser4 opened this issue May 4, 2024 · 0 comments

Comments

@ShadowChaser4
Copy link

Background:
I wish to auto login my local users if they choose logging in via google with same email address. However, during social login validation on serializers there is a condition:

        if not login.is_existing:
            # We have an account already signed up in a different flow
            # with the same email address: raise an exception.
            # This needs to be handled in the frontend. We can not just
            # link up the accounts due to security constraints

The security concern is valid however google does provide, email_verified value in their response, and one can argue that it would be safe to let the social login continue if the email is verfied.
I wish to propose such configuration as to let devs working on project themselves decide whether or not to let the auto-link be done.
The configuration might only be limited to such providers who return email_verified property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant