Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actual Implementation of verifySignedRequest Not Tested Due to Stubbing #48

Open
akhileshthite opened this issue Feb 28, 2024 · 0 comments
Open

Actual Implementation of verifySignedRequest Not Tested Due to Stubbing #48

akhileshthite opened this issue Feb 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@akhileshthite
Copy link
Collaborator

Currently, in our tests for the ActivityPubSystem, by stubbing the method aps.verifySignedRequest, we're bypassing its actual implementation and immediately returning a resolved promise with a predefined value. This means the real logic of verifySignedRequest is never executed during the test.

  • We should only stub fetch and use a regular store and keep all the other apis as is if possible.

Revisit the tests after M3
@fauno fauno added the enhancement New feature or request label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Distributed Press Organizing
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fauno @akhileshthite