Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] combine some features in the setting options #671

Open
wxharry opened this issue May 17, 2023 · 1 comment
Open

[Feature] combine some features in the setting options #671

wxharry opened this issue May 17, 2023 · 1 comment
Labels
good first issue Good for newcomers kind/feature Category issues or prs related to feature request. waiting for repliers

Comments

@wxharry
Copy link
Collaborator

wxharry commented May 17, 2023

Also, I think perceptor-layout, perceptor-tab, and repo-networks can be combined into one option. The Perceptor button at the top is still displayed when the perceptor-layout and repo-networks options are not selected, however perceptor-tab option works well.
image

Originally posted by @lhbvvvvv in #659 (comment)

@menbotics menbotics bot added the kind/feature Category issues or prs related to feature request. label May 17, 2023
@wxharry
Copy link
Collaborator Author

wxharry commented May 23, 2023

Here is a possible quick solution to fix this:

  1. modify the index file for importing all features. Separate layout elements like perceptor tab and perceptor layout with other charts and tags.
  2. improve the file parser in the loader to get only the features that are not related to layout

In the above solution, we think of all features on the same level and to ignore those strucuture related features in the options is feasible.

However, the layout is more like a upper layer for the charts in that layout. So, it could be better we could reflect that relationship, which means if a user blocks the layout, all the elements inside that layout will be automatically disabled. Or, if one element can be enabled only if all its layout elements are enabled.
Further researches and discussions are needed for the advanced solution.

@wxharry wxharry changed the title feat: combine some features in the setting options [Feature] combine some features in the setting options Jun 4, 2023
@wxharry wxharry added the good first issue Good for newcomers label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature Category issues or prs related to feature request. waiting for repliers
Projects
Status: No status
Development

No branches or pull requests

1 participant