Add service for dynamic config #61
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank11p
commented
Apr 7, 2021
| } | ||
|
|
||
| // InitialConfigurationRequest has information about the agent | ||
| message InitialConfigurationRequest { |
There was a problem hiding this comment.
Not using service_name here as a user will anyways define it in env var or system property and they have higher preference so it will be updated by agents. Do we have any other use case for sending service_name?
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #60
Resolves #58
Defines a grpc service to get the configuration in agents dynamically from a service.
It defines two rpc, one for getting the initial config for agent at startup, and another to get dynamic configuration that can be updated at runtime without restarting the agent.
The preference in order for config at agent startup should be (from low to high)
After startup, the dynamic config returned by UpdateConfiguration should be applied and configuration timestamp updated in agents.