Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture config per framework/instrumentation #3

Open
pavolloffay opened this issue Oct 30, 2020 · 3 comments
Open

Capture config per framework/instrumentation #3

pavolloffay opened this issue Oct 30, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@pavolloffay
Copy link
Member

The capture config should be configurable per framework/instrumentation but also globally (

message DataCapture {
).

For instance I want to disable body capture for servlet but still have it enabled for okhttp client.

@pavolloffay pavolloffay added the enhancement New feature or request label Oct 30, 2020
@jcchavezs
Copy link
Contributor

While I see the consequences of the use case legit, I'd really like to run some discussion around this as I believe people is not too interested on enable/disable per library but probably per use case (e.g. client, server, remote service, etc). Any thoughts on this @davexroth @mohit-a21 ?

@pavolloffay
Copy link
Member Author

The use case I had in mind was that particular body instrumentation can be problematic so it could be disabled without affecting others.

@davexroth
Copy link

Exactly, it will mostly be something used by us in the field if a particular framework causes issues in a customers application.

But as it will be more of an internal config, we may be able to have a different config block such as message Frameworks { map of framework name to options }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants