-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document environment variable names #11
Comments
Go SDK https://github.com/hypertrace/goagent/tree/main/config#agent-config-go already supports some env vars. It can be a good starting point. |
The precende (at least in goagent) is
So env vars override config file values and defaults. The naming we took in go was to flatten the keys in the config structure. For example: |
The precedence order looks fine. Another topics:
|
We should consider changing this to
|
I'd prefer to not to fail when it comes to instrumentation. That would cause the so called observed effect. Instead I would try to run normally and drop a log line with the error.
I think
I think not making camelcase elements like dataCapture or httpHeaders into snake case makes it less readable and I would not sacrifice that for the convenience of parsing. Also I am not sure if you intented to add that dot in the middle of |
The properties in the config should be overridable by the environment variables (and system properties e.g. in Java). The names of the variables should be documented and consistent across clients.
The text was updated successfully, but these errors were encountered: