Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages for estimateGas failures #76

Open
shorsher opened this issue Apr 26, 2023 · 0 comments
Open

Improved error messages for estimateGas failures #76

shorsher opened this issue Apr 26, 2023 · 0 comments

Comments

@shorsher
Copy link
Member

shorsher commented Apr 26, 2023

Currently, some estimateGas failures result in an "" being passed to firefly. This seems to be because "" is the default catch in mapError.

The log message that is printed Gas estimation failed for a non-revert reason: is much more helpful than the empty string passed back to FireFly.

Example error log:

{"@timestamp":"2023-04-25T11:35:59.627Z","level":"error","message":"Gas estimation failed for a non-revert reason:  (call result: \u003cnil\u003e)","prefix":"evmconnect"}

Error reported by FireFly in failed operation:

FF10111: Error from ethereum connector: {"error":""}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant