-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default server configuration prevents the use of server pushes #755
Comments
Interesting find. I see how that'd be a problem, yea. A PR to change that is welcome. |
There was some head scratching involved when I couldn't get server push working between a h2 client and server. The workaround is to have the client always send a
Will do soon. Any opinions on a default value ? I will also add a method to the server |
Unless there's prior art we can copy, an educated guess makes sense.
|
h2/src/server.rs
Lines 1378 to 1379 in a8af235
This is arguably a bad default, given that it will block any server pushes unless the client explicitly sends a non-zero
MAX_CONCURRENT_STREAMS
setting.I don't think we should limit the server that way unless the client explicitly requests that.
The text was updated successfully, but these errors were encountered: