-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow redirects where Access-Control-Allow-Origin
header is restrictive
#327
Comments
Something I'm playing around with on my project (that is working) right now is having a File below:
And instead of
Right now there is a problem going back after navigating to the redirect location, but it'll likely be an easier solve for me. If anyone has any insight into this, it's very welcome! |
Similar issue to #320, but it is slightly different.
I want to be able to handle external redirects to servers that do not have open
Access-Control-Allow-Origin
headers. I don't think there is a bug in the code, but I'd like to know where to hook in inside my android app to pop-up a CustomTab or something like that.Here is an example of what I'm looking for:
Screen.Recording.2024-04-03.at.2.51.59.PM.mov
The external redirect works when it goes to https://turbo.hotwired.dev because of it's open
Access-Control-Allow-Origin
header.The important bit in those headers is that access-control-allow-origin is set to allow all domains. But how should the turbo-android package handle it if we don't have access to set those headers (on, say, a third-party provider)? One option is to set up a proxy, but I'd love to avoid setting up any new infrastructure, as this works perfectly fine in a browser.
I'm working off of main on turbo-android (version 7.1.2), and using this server running locally: https://github.com/hjhart/turbo-native-demo
I think I should be breaking out of turbo, but I don't seem to have the proper hooks firing to do so (shouldNavigateTo doesn't fire, for instance).
Any input?
cc @jayohms I created a new issue since the previous issue was addressed and closed!
The text was updated successfully, but these errors were encountered: